Skip to content

fix: add ref support for Web #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2022
Merged

fix: add ref support for Web #376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87a0df3
fix: add ref support for Web
LucioChavezFuentes Feb 10, 2022
1e50651
fix lint errors
LucioChavezFuentes Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions js/Picker.web.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import * as React from 'react';
import * as ReactNativeWeb from 'react-native-web';
import {forwardRef, useRef} from 'react';
import {forwardRef} from 'react';
import type {ViewProps} from 'react-native-web/src/exports/View/types';
import type {GenericStyleProp} from 'react-native-web/src/types';
import type {TextStyle} from 'react-native-web/src/exports/Text/types';
Expand All @@ -31,7 +31,10 @@ type PickerProps = {
};

const Select = forwardRef((props: any, forwardedRef) =>
ReactNativeWeb.unstable_createElement('select', props),
ReactNativeWeb.unstable_createElement('select', {
...props,
ref: forwardedRef,
}),
);

const Picker: React$AbstractComponent<PickerProps, empty> = forwardRef<
Expand All @@ -49,8 +52,6 @@ const Picker: React$AbstractComponent<PickerProps, empty> = forwardRef<
...other
} = props;

const hostRef = useRef(null);

const handleChange = React.useCallback<any>(
(e: Object) => {
const {selectedIndex, value} = e.target;
Expand All @@ -66,7 +67,7 @@ const Picker: React$AbstractComponent<PickerProps, empty> = forwardRef<
<Select
disabled={enabled === false ? true : undefined}
onChange={handleChange}
ref={hostRef}
ref={forwardedRef}
value={selectedValue}
{...other}
/>
Expand Down