Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Overlay onPress event for Android #3007

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

formatlos
Copy link
Contributor

Does any other open PR do the same thing?

No

What issue is this PR fixing?

Adds onPress callback and tappable prop to Overlay on Android.
Fixes the issue that the MapView onPress events are getting swallowed by Overlays.

How did you test this PR?

Tested with emulator and physical device on Android.

Add onPress callback handlers to the overlay and the MapView.
With tappable set true the callback of the overlay fires as expected. With tappable set false the callback of the MapView fires.

@rborn
Copy link
Collaborator

rborn commented Aug 7, 2019

LGTM ❤️

@christopherdro @alvelig 🐽

Question: do we have this for iOS already? i not can be implemented for platform parity?

@formatlos
Copy link
Contributor Author

@rborn as far as I saw it's not implemented for iOS. I gave it a quick try, but I'm so not into iOS stuff

@rborn rborn merged commit b8f2bfa into react-native-maps:master Aug 14, 2019
@adnkh
Copy link

adnkh commented Sep 25, 2019

Really thanks for this ❤️

Exited to see it in the next release

netmaxt3r pushed a commit to netmaxt3r/react-native-maps that referenced this pull request Oct 6, 2019
* commit '3ae31e4a336102538ee422a0d4e71a2ea32647bb': (24 commits)
  [0.26.1] Release
  rn 0.60.5 support (react-native-maps#3020)
  "AIRMap" was not found in the UIManager IN "0.26.0" (react-native-maps#3103)
  [0.26.0] Release
  Add Heatmap back in (react-native-maps#3064)
  Fixes NPE while removing already removed marker. (react-native-maps#3032)
  Add flat property binding on Marker for iOS (react-native-maps#3051)
  Add heading to the onUserLocationChange listener (react-native-maps#3045)
  Add onDoublePress callback (react-native-maps#2937)
  Allow using onPanDrag while scrollEnabled=true (react-native-maps#2935)
  updating pods for compile error (react-native-maps#3011)
  add overlay onPress event (react-native-maps#3007)
  Fix playServicesVersion name in installation docs (react-native-maps#3016)
  Update index.d.ts (react-native-maps#2887)
  Add @ReactModule annotation to help turbomodules processor (react-native-maps#3001)
  Google Maps - Heatmaps for Android and iOS (react-native-maps#2960)
  Added GeoJSON support by default (react-native-maps#2959)
  Update GoogleMaps pos to 3.2.0 (react-native-maps#2999)
  convert to new react native config format (RN 0.60 (react-native-maps#2975)
  fix select annotation when show/hide callout view (react-native-maps#2973)
  ...

# Conflicts:
#	package.json
yuheidapperapps added a commit to yuheidapperapps/react-native-maps that referenced this pull request Oct 15, 2019
* master: (31 commits)
  Wider Note column (prevent horisontal scroll) (react-native-maps#3130)
  replaced deprecated bridge.imageLoader calls with moduleForClass API (react-native-maps#3125)
  Implement onUserLocationChange in AIRMap (react-native-maps#2889)
  keep current mapType when taking snapshot (react-native-maps#3120)
  Add mapPadding on iOS maps (react-native-maps#3119)
  [iOS] Expose isAccessibilityElement as a prop (react-native-maps#3115)
  Add supportLibVersion safeguard in gradle build (react-native-maps#3106)
  [0.26.1] Release
  rn 0.60.5 support (react-native-maps#3020)
  "AIRMap" was not found in the UIManager IN "0.26.0" (react-native-maps#3103)
  [0.26.0] Release
  Add Heatmap back in (react-native-maps#3064)
  Fixes NPE while removing already removed marker. (react-native-maps#3032)
  Add flat property binding on Marker for iOS (react-native-maps#3051)
  Add heading to the onUserLocationChange listener (react-native-maps#3045)
  Add onDoublePress callback (react-native-maps#2937)
  Allow using onPanDrag while scrollEnabled=true (react-native-maps#2935)
  updating pods for compile error (react-native-maps#3011)
  add overlay onPress event (react-native-maps#3007)
  Fix playServicesVersion name in installation docs (react-native-maps#3016)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants