Remove deprecated API #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @divyanshu013, I’ve noticed that you removed optional chaining on |
|
Oh didn't know about this, was following the docs. I tested this out on my device as well but didn't see any issues. Have you seen this in some particular case? |
|
Unfortunately I don’t know how to reproduce it on my app, it seems it’s totally random and it happens from time to time. I’ve seen other popular modules using an optional chaining for that reason, eg: https://github.com/ammarahm-ed/react-native-actions-sheet/blob/c2a266e0385b373f06332d44684be6399fe6232a/src/index.tsx#L560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.