Skip to content

Resolve Missing Deploy Target in Windows#311

Merged
vonovak merged 2 commits intoreact-native-datetimepicker:masterfrom
chiaramooney:fix-deploy-issue
Oct 17, 2020
Merged

Resolve Missing Deploy Target in Windows#311
vonovak merged 2 commits intoreact-native-datetimepicker:masterfrom
chiaramooney:fix-deploy-issue

Conversation

@chiaramooney
Copy link
Contributor

Summary

Fix error produced when module is added to a React Native app and run in Windows emulator.
Error reads: "The target "Deploy" does not exist in the project".

Test Plan

Create a React Native Windows app.
Add datetimepicker module to app via yarn add.
Run npx react-native run-windows.
If app deploys successfully and loads in the Windows emulator, the code change has succeeded.

What's required for testing (prerequisites)?

A React Native Windows app. See here for setup instructions.

What are the steps to reproduce (after prerequisites)?

To reproduce error, run steps under "Test Plan" with old version of the module.

Compatibility

OS Implemented
iOS
Android
Windows

Checklist

  • [X ] I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@vonovak vonovak merged commit 5c8d7b0 into react-native-datetimepicker:master Oct 17, 2020
@vonovak
Copy link
Member

vonovak commented Oct 17, 2020

thank you!

vonovak pushed a commit that referenced this pull request Oct 17, 2020
## [3.0.4](v3.0.3...v3.0.4) (2020-10-17)

### Bug Fixes

* Resolve Missing Deploy Target in Windows ([#311](#311)) ([5c8d7b0](5c8d7b0))
@vonovak
Copy link
Member

vonovak commented Oct 17, 2020

🎉 This PR is included in version 3.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants