refactor: automation to tag and version the template when releasing #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update GHA scripts to point to correct folder
Sets the version of react-native and the @react-native/ scoped packages. It will also normalize tags to concrete versions. E.g. latest -> 0.74.2
Support for doing this on nightly and release workflows
blakef
commented
Jun 20, 2024
| @@ -0,0 +1,25 @@ | |||
| const {execSync} = require('child_process'); | |||
Collaborator
Author
There was a problem hiding this comment.
Most of this code was moved from the CLI. See react-native-community/cli/pull/2422 for the matching change in CLI, where these were removed.
2 tasks
cortinico
approved these changes
Jun 20, 2024
cipolleschi
approved these changes
Jun 21, 2024
blakef
changed the title
cortinico
pushed a commit
that referenced
this pull request
Jun 21, 2024
) There was a discussion on Discord, where we looked at implementing what was originally proposed. This is that implementation. It'll need to land with a [cli](react-native-community/cli#2422) change to use the update template + tagging. - feat: add mutating react-native & @react-native/ packages Support for doing this on nightly and release workflows - feat: added node ./scripts/updateReactNativeVersion.js <version> Sets the version of react-native and the @react-native/ scoped packages. It will also normalize tags to concrete versions. E.g. latest -> 0.74.2 - refactor: move scripts into a ./scripts folder
Member
|
I've picked this on the release branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There was a discussion on Discord, where we looked at implementing what was originally proposed. This is that implementation. It'll need to land with a cli change to use the update template + tagging.
feat: add mutating react-native & @react-native/ packages
Support for doing this on nightly and release workflows
feat: added node ./scripts/updateReactNativeVersion.js
Sets the version of react-native and the @react-native/ scoped packages.
It will also normalize tags to concrete versions. E.g. latest -> 0.74.2
refactor: move scripts into a ./scripts folder
Changelog:
[Internal] Update react-native and @react-native packages in the template when publishing to npm.
Test Plan:
Not sure really, have run the script locally and it updates as expected. For the GHA actions 👀.