fix publish to docker hub #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@gengjiawen please merge 👍 and maybe release proper 1.0 version |
gengjiawen
reviewed
Oct 27, 2020
Member
|
Can you go through on a full release in your fork, I am afraid we will make the git commit log ugly with too many failed tried https://github.com/dulmandakh/docker-android/actions?query=workflow%3APublish |
Contributor
Author
|
@gengjiawen publish action is running on https://github.com/dulmandakh/docker-android/runs/1314705293, but won't push to Docker Hub |
dulmandakh
force-pushed
the
fix-publish-docker-hub
branch
3 times, most recently
from
3c9d6f6 to
c50af60
Compare
Contributor
Author
|
@gengjiawen it successfully built docker image, and here is a snippet from docker build jobs with proper tags /usr/bin/docker buildx build --tag reactnativecommunity/react-native-android:1.0 --tag reactnativecommunity/react-native-android:latest --iidfile /tmp/docker-build-push-QYnCf2/iidfile --secret id=GIT_AUTH_TOKEN,src=/tmp/docker-build-push-QYnCf2/tmp-2709-IwHeEg27BHT1 --file ./Dockerfile https://github.com/dulmandakh/docker-android.git#tags/v1.0
13 |
Member
|
Please revert |
dulmandakh
force-pushed
the
fix-publish-docker-hub
branch
from
c50af60 to
3e9e059
Compare
dulmandakh
force-pushed
the
fix-publish-docker-hub
branch
from
3e9e059 to
1b084a1
Compare
Contributor
Author
|
@gengjiawen done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the publish action conditions, also build action will ignore version tags