bump Buck to 2020.09.09.01 #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@gengjiawen it's ready to merge. Please merge |
gengjiawen
requested changes
Oct 18, 2020
Member
gengjiawen
left a comment
gengjiawen
left a comment
There was a problem hiding this comment.
I don't think we should bundle two ndk until the code ready. This will make the image much bigger.
If you want to debug the new ndk, there will be many ways. I don't this will be a good idea.
Contributor
Author
|
I'm doing this per discussion on facebook/react-native#29013 |
Member
Still the point stands. If you want to try new ndk, you can use circleCI remote ssh or personal docker image. |
Contributor
Author
|
ok, removed NDK 21. Bumping Buck and Android command line tools. |
gengjiawen
approved these changes
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump Buck to 2020.09.09.01, and Android command line tools to latest version.