Bump SDK version to 33 #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
reviewed
Nov 4, 2022
Comment on lines
+7
to
+9
| # Keep the previous SDK as a fallback until we've finished the migration. | ||
| ARG ANDROID_BUILD_VERSION_FALLBACK=31 | ||
| ARG ANDROID_TOOLS_VERSION_FALLBACK=31.0.0 |
Member
There was a problem hiding this comment.
I don't think you need those. AGP will download on demand previous build tool versions
Contributor
Author
There was a problem hiding this comment.
Good to know! I was following the same upgrade strategy as in https://github.com/react-native-community/docker-android/pull/185/files.
Contributor
Author
|
Circle CI is failing with "Bootstrap classpath /opt/android/platforms/android-31/android.jar contains no valid entries": P545999530. |
Contributor
Author
|
@cortinico it seems we actually need the fallback SDK version, otherwise Circle CI fails with an error: P545999530. |
cortinico
approved these changes
Nov 5, 2022
Member
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
@cortinico it seems we actually need the fallback SDK version, otherwise Circle CI fails with an error: P545999530.
Yup you're right 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to upgrade the Docker image to SDK 33 before upgrading React Native in facebook/react-native#35196.