Skip to content

Conversation

@dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Oct 31, 2020

I would like to make purpose of the image clear and install required packages.

  • build React Native
  • build React Native apps/libraries

So I would like to propose some breaking changes and v2:

  • remove python version 2. Buck no longer requires it. Will save more than 20MB
  • headless jdk. we're saving around 114 MB because we don't install many fonts and libraries required to run emulator in UI mode. Anyone can use the image as base, and install full jdk.
  • remove cmake (apt): we save around 75.3 MB, nevertheless we'll install cmake using sdkmanager
  • remove ruby. Maybe we can provide another image with fastlane.

Also updated publish job to update latest tag only if version 1.x published. We can change that when we're sure that v2 is stable.

NOTE: created v1 branch

@dulmandakh dulmandakh changed the title remove python, switch to wget v2 Oct 31, 2020
@dulmandakh dulmandakh changed the title v2 WIP: v2 Oct 31, 2020
@gengjiawen
Copy link
Member

I am +1 on python, -1 on curl. Curl is more general http tools, wget only for download.

@dulmandakh
Copy link
Contributor Author

curl is very generic networking tool with support for many protocols like sftp, ldap and etc. We can save around the 10MB, and see that wget is just enough for downloading required packages and files. Maybe we can keep curl and have carry around 10MB in the image. You decide.

@gengjiawen
Copy link
Member

It's only 10Mb. And I sometimes use it to upload my apk using curl command. Let's keep it.

@dulmandakh
Copy link
Contributor Author

dulmandakh commented Oct 31, 2020

@gengjiawen please review and feel free to squash merge it

@dulmandakh
Copy link
Contributor Author

Let's adopt semantic versioning, and bump major version if we introduce breaking change. Also publish major version tag, so that developers receive updates easily.

@dulmandakh dulmandakh changed the title WIP: v2 v2 Oct 31, 2020
@dulmandakh dulmandakh changed the title v2 WIP: v2 Oct 31, 2020
@dulmandakh dulmandakh changed the title WIP: v2 v2 Oct 31, 2020
@dulmandakh dulmandakh merged commit 95ba787 into react-native-community:master Nov 1, 2020
@dulmandakh dulmandakh deleted the v2 branch November 1, 2020 01:49
@thibmaek
Copy link

Is there an alternative image with bundler/fastlane available already? @dulmandakh

@dulmandakh
Copy link
Contributor Author

You can go to releases page and see what's changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants