Skip to content

Conversation

@0xFA11
Copy link
Contributor

@0xFA11 0xFA11 commented Jul 17, 2024

πŸ“ Why & how

Update bottom sheet (as requested by @brentvatne over here: reactwg/react-native-new-architecture#167 (reply in thread))

βœ… Checklist

  • Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json
  • Documented in this PR how to use the feature or replicate the bug.
  • Documented in this PR how you fixed or created the feature.

@Simek
Copy link
Member

Simek commented Jul 17, 2024

Hey @ThusSpokeNomad, looks like something lead to the reformatting in the whole data file. Usually, we would need to revert those changes, but in this case, it looks like we can close the PR, since given library is already present in the directory:

We have a deduplicate mechanism, which should fail the CI, but it did not work in this case for some reason, going to investigate the checks.

@0xFA11 0xFA11 changed the title Add Bottom Sheet Update Bottom Sheet Jul 17, 2024
@0xFA11
Copy link
Contributor Author

0xFA11 commented Jul 17, 2024

hey @Simek nice catch, I didn't see that!
let's consider this as an update then?
I also reverted formatting changes too.

Copy link
Member

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks for the updates! πŸ‘

@Simek Simek merged commit 23137e9 into react-native-community:main Jul 17, 2024
@0xFA11 0xFA11 deleted the bottom-sheet branch July 17, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants