feat: set a default symbolicator.customizeFrame value
#596
Conversation
motiz88
force-pushed
the
symbolicator-customize-frame-defaults
branch
from
4cc46fe
to
1a05e6e
Compare
|
Since this is a new config option, older Metro versions (used by RN 0.60) will spawn a validation warning, like this:
Which may confuse people. Can you add a check to only include this if newer version of Metro is used? |
|
Also, I'm so happy you work on this space to make errors more approachable ❤️ |
|
@thymikee Is there a scenario where people use a new CLI version with an old Metro version? Would it be enough to hold off on merging this until we cut a new Metro release and bump the dependency here? |
|
If you could update Metro without breaking changes, then we could bump it internally here, provided it doesn't clash with RN. It still internally relies on 3 Metro packages: https://github.com/facebook/react-native/blob/59db059dbddb8101212f3739eecf0db494cfab41/package.json#L103-L105, which makes us (the CLI) to be up to date with what's there. If you could also make it so that all Metro deps are required from the CLI (which makes sense), that would make us in charge of what's breaking or not. It would also make RN bundler-agnostic at the core. And in theory we could bump major Metro versions without a breaking change. |
|
We are having quite a bunch of big changes in Metro related to changes in RN. We are hoping to bump Metro to 0.56 this week and update the CLI and RN. Could we merge this change as part of that? RN master/0.61 will only work with Metro 0.56 and above. |
|
Ok, let's wait for Metro 0.56, merge this alongside and put 2.x into a branch for maintenance mode. cc @Esemesek if you feel like moving some CLI stuff to TS, this is the time, as structural changes will be hard to port between branches. |
Summary: Changes `ExceptionsManager` to respect the `collapse` field in each symbolicated stack frame returned from Metro. This is ultimately driven by a Metro config option (which will have a default set in react-native-community/cli#596). This is part of a redesign of work done originally in facebook#24662. Reviewed By: cpojer Differential Revision: D16500277 fbshipit-source-id: bded9a7b037b9f944b27125d43e35fcce5bd109a
Summary: Pull Request resolved: #25839 Changes `ExceptionsManager` to respect the `collapse` field in each symbolicated stack frame returned from Metro. This is ultimately driven by a Metro config option (which will have a default set in react-native-community/cli#596). This is part of a redesign of work done originally in #24662. Reviewed By: cpojer Differential Revision: D16500277 fbshipit-source-id: b0b035618cb000935a555796523637b5f0a688d3
|
With #630 now merged, I think we can merge this as well? |
|
@motiz88 yep! Could you rebase and fix Flow? |
motiz88
force-pushed
the
symbolicator-customize-frame-defaults
branch
from
1a05e6e
to
41ac1e8
Compare
|
Done. The failure in e2e-tests also exists on master: https://circleci.com/gh/react-native-community/cli/8256 |
|
@motiz88 FYI this is available in |
Summary: Removes support for the non-standard `framesToPop` error property from React Native. Redboxes will now ignore this field. The way to skip uninformative frames in stack traces going forward is to use Metro's `customizeFrame` config option, for which the React Native CLI ships useful defaults (see: react-native-community/cli#596, react-native-community/cli#780) Changelog: [General] [Removed] - Remove support for framesToPop from ExceptionsManager Reviewed By: rickhanlonii Differential Revision: D17877444 fbshipit-source-id: 04aa332c45ad35a99ae20e05fb87b34c91a557ab
Summary:
Sets a default
symbolicator.customizeFramevalue. This configuration option was added to Metro in facebook/metro#435.This is part of a redesign of facebook/react-native#24662.
Test Plan:
Equivalent config change tested as part of facebook/react-native#25839.