Skip to content

Conversation

@szymonrybczak
Copy link
Collaborator

Summary:

We were checking for Yarn major to be higher than 1, which is okay ✅ but we also checked in every scenario for minor to be higher than 22, which e.g for Yarn version 3.6.4 is not the case and CLI was running yarn policies set-version x.y.z for Yarn v3 which was throwing an error, and PnP was used.

Test Plan:

  1. Use Yarn v3/v4 globally
  2. Clone the repository and do all the required steps from the Contributing guide
  3. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js init
  1. Packages should be installed with yarn and nodeLinker: node-modules should be used.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak szymonrybczak merged commit 6546159 into main Jun 24, 2024
@szymonrybczak szymonrybczak deleted the fix/correctly-check-yarn-version branch June 24, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants