refactor: improved type safety of platformConfig in createRun function #2286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I improved type safety of
platformConfig
increateRun
function. and removed unnecessary optional chaining of theplatformConfig
.(code is located in cli-platform-apple/src/commands/runCommand/createRun.ts)
before I modified type of
platformConfig
, we couldn't infer that platformConfig could beundefined
.so, I added
undefined
type toplatformConfig
as optional.Additionally, there was unnecessary optional chaining, so I removed it.
Test Plan:
We need to check that the function is working properly, even if we put a platformName that is invalid.
Checklist