Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression where run was executing multiple times #2242

Merged

Conversation

okwasniewski
Copy link
Contributor

@okwasniewski okwasniewski commented Jan 3, 2024

Summary:

This PR fixes a regression where builds were executed multiple times because of missing return statement (Introduced during refactor #2208).

This code before cli-platform-apple refactor:

return runOnBootedDevicesSimulators(

Issue screenshot:

image

Test Plan:

  1. Run yarn ios and check if build happens only once

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thymikee thymikee merged commit 4d70c81 into react-native-community:main Jan 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants