Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only run app on booted and available devices #2225

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

Regression implemented #2208

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios
  1. Should only run on devices once it booted and available.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak szymonrybczak changed the title fix: only iterate on booted devices fix: only iterate run on booted and available devices Dec 21, 2023
@szymonrybczak szymonrybczak changed the title fix: only iterate run on booted and available devices fix: only run app on booted and available devices Dec 21, 2023
@thymikee thymikee merged commit fc11714 into main Dec 21, 2023
8 of 10 checks passed
@thymikee thymikee deleted the fix/iterate-only-on-booted-devices branch December 21, 2023 10:48
@thymikee
Copy link
Member

Btw, we should disable that flaky test on node 20 and schedule some time to address it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants