Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): launching app on simulator with different appId than pa… #2195

Merged
merged 1 commit into from
Dec 10, 2023
Merged

fix(android): launching app on simulator with different appId than pa… #2195

merged 1 commit into from
Dec 10, 2023

Conversation

thymikee
Copy link
Member

@thymikee thymikee commented Dec 7, 2023

Summary:

Fixes #2194

Test Plan:

Added a test for tryLaunchAppOnDevice covering this scenario and a handful of others. The tests fail without the change introduced.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee thymikee requested a review from cortinico as a code owner December 7, 2023 14:36
@github-actions github-actions bot added the bugfix label Dec 7, 2023
TMisiukiewicz
TMisiukiewicz approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@TMisiukiewicz TMisiukiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, all works - LGTM! E2E are constantly failing 🥲

@thymikee thymikee merged commit 11c4bec into main Dec 10, 2023
4 of 10 checks passed
@thymikee thymikee deleted the fix/appid branch December 10, 2023 18:27
thymikee added a commit that referenced this pull request Dec 11, 2023
@thymikee
fix(android): launching app on simulator with different appId than pa…
5862d7a 
…ckageName (#2195)
@thymikee thymikee mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TMisiukiewicz TMisiukiewicz TMisiukiewicz approved these changes

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On Android, app isn't opened automatically if applicationId is changed
3 participants
@thymikee @cortinico @TMisiukiewicz