refactor(iOS): remove unintended flags from build-ios #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
approved these changes
Sep 18, 2023
Collaborator
szymonrybczak
left a comment
szymonrybczak
left a comment
There was a problem hiding this comment.
Great cleanup! 🙌 I still see some flags such us --binary-path or --list-devices under build-ios command instead of run-ios in docs ;/ We need to fully sync docs with codebase.
adamTrz
approved these changes
Sep 20, 2023
Collaborator
adamTrz
left a comment
adamTrz
left a comment
There was a problem hiding this comment.
Thanks for the cleanup, works like a charm 💪
This was referenced Sep 26, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
build-ioscommand contained some left-over flags fromrun-ioslike simulator, uuid, device. Removed the references and moved the code a bit to remove duplication.As a followup we should focus on bringing interactive behavior as default
Test Plan:
Checklist