fix: schema validation errors disguised as warnings #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will work on unit tests tomorrow |
…es with invalid conifg
thymikee
force-pushed
the
fix/warning-errors
branch
from
1eb7995 to
42f16ae
Compare
thymikee
added a commit
that referenced
this pull request
Jul 8, 2022
* fix: schema validation errors disguised as warnings * update lockfile * change test accordintly to the change of behavior for skipping packages with invalid conifg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When Joi validates the schema, it will abort early and thus prevent us from constructing the rest of the configuration, which might be correct. In such case the CLI would emit a warning that configuration for a certain package was invalid. However what this warning wouldn't tell is that the library failed to autolink completely.
This PR changes the Joi validation to not abort early and make warnings what they really are, without preventing the schema object to be created.
This caused issues like this one: reactwg/react-native-releases#23
Test Plan:
Adjusted the wording of the warning: