Bump room to 2.4.2, allowing arm64 jdk compile

[danilobuerger]

Summary

Starting with room 2.4.0-alpha03 arm64 is supported allowing native compile with a arm64 jdk.

Test Plan

1. Get yourself an m1
2. brew tap mdogan/zulu
3. brew install --cask zulu-jdk11
4. java -version (make sure you are running zulu)
5. any repo with rn and async-storage included
6. react-native run android (build will fail)
7. apply patch
8. react-native run android (build will succeed)

[danilobuerger]

I don't really know why it would still include jetified-kotlin-reflect-1.5.31.jar in the test. Maybe a cache problem?

[tido64]

I don't really know why it would still include jetified-kotlin-reflect-1.5.31.jar in the test. Maybe a cache problem?

I think this is because our test app is still on 1.5. I'm looking into bumping to 1.6 now:

• chore(deps): update moshi to v1.13.0 microsoft/react-native-test-app#813
• chore(deps): update kotlin to v1.6.10 microsoft/react-native-test-app#651 chore(deps): update kotlin to v1.6.10 microsoft/react-native-test-app#814

[tido64]

A new version of the test app with Kotlin 1.6.10 is out. Can you try bumping react-native-test-app to 1.2.1?

async-storage/package.json

Line 91 in 2c2cc6d

"react-native-test-app": "^1.2.0",

[danilobuerger]

Bumped and test passes now. Thanks for the help

[tido64]

@krizzu: Can you please review this? I think you had some objections to bumping Room in the past, but it currently looks like it will break on react-native 0.68 + M1.

Also, I can't test this because step 1 fails for me 😛

[danilobuerger]

Side note: It will only fail on m1 if using an arm64 jdk.

[krizzu]

@tido64 Great, I hoped to get an Kotlin update in test-app soon 🙏

@danilobuerger This looks great. My only concern in bumping Room, was because the 2.4.0+ requires compileSdk 31 and I did not want to force anyone (even if it's recommended to use latest one). That's why I gave an option to set Room version through properties.

But I think it might be good to go up now, especially with RN 0.68 💪

[krizzu]

Btw, @danilobuerger , any particular reason for Zulu dist? Or it's just personal preference?

[danilobuerger]

Btw, @danilobuerger , any particular reason for Zulu dist? Or it's just personal preference?

@krizzu Just to get my hands on an arm64 jdk 11 build. For example temurin 11 does not have an arm64 build yet.

[krizzu]

This is great, thank you

[krizzu]

Btw, @danilobuerger , any particular reason for Zulu dist? Or it's just personal preference?

@krizzu Just to get my hands on an arm64 jdk 11 build. For example temurin 11 does not have an arm64 build yet.

Make sense, I see temurin has arm64 available for jdk17 only. Thanks!

[danilobuerger]

adoptium/adoptium#96 for reference on temurin 11 arm64

[krizzu]

@tido64 If you don't have anything else, feel free to merge

[tido64]

@tido64 If you don't have anything else, feel free to merge

Sure, only question I have is whether this should be a minor or patch bump. It feels like it should be minor since we bumped the SDK. What do you think?

[krizzu]

@tido64 Yes, I also think this is minor. I'll add annotation to release notes, that we're using higher version of SDKs and require compileSdk 31

[tido64]

Thanks for taking the time to investigate and fix this ❤️

[krizzu]

🎉 This PR is included in version 1.17.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[mikehardy]

I mentioned this to @tido64 on discord - but in the release notes you should definitely note that compileSdkVersion 31 strictly requires JDK11. JDK8 will suffer internal compiler errors when confronted with the 31 SDK

given the compileSdkVersion bump required and JDK11 bump required, might be a major version but that's a philosophical question :-)

[krizzu]

thanks @mikehardy , I updated release notes to also include a workaround, to use old version of Room/Kotlin, if one is not ready to upgrade