Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade sample apps to use react-native 61 #329

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Upgrade sample apps to use react-native 61 #329

merged 1 commit into from
Apr 17, 2020

Conversation

kaiguo
Copy link
Contributor

@kaiguo kaiguo commented Apr 11, 2020

Summary:

Fixes #328.
Upgraded iOS and Android samples to use react-native 0.61.5.

Test Plan:

Run sample apps as before.

@kaiguo
Copy link
Contributor Author

kaiguo commented Apr 11, 2020 •
edited
Loading

I keep getting this Worker interrupted with signal: sigkill error during flow check, not sure if it's pipeline issue or me.

https://circleci.com/gh/react-native-community/async-storage/2160?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Local yarn test:flow run seems fine.

@kaiguo kaiguo mentioned this pull request Apr 11, 2020
Merged
@krizzu
Copy link
Member

krizzu commented Apr 12, 2020

@kaiguo Try setting max worker to 1 in config
https://flow.org/en/docs/config/options/#toc-server-max-workers-integer

krizzu
krizzu reviewed Apr 12, 2020
View reviewed changes
example/ios/Podfile.lock Outdated Show resolved Hide resolved
@krizzu krizzu changed the base branch from LEGACY to master April 12, 2020 17:05
@kaiguo kaiguo force-pushed the upgrade-sample-app-to-61 branch 3 times, most recently from 2617b8c to f20cb90 Compare April 13, 2020 19:33
@kaiguo kaiguo force-pushed the upgrade-sample-app-to-61 branch from f20cb90 to 3a8d923 Compare April 13, 2020 19:44
@kaiguo
Copy link
Contributor Author

kaiguo commented Apr 13, 2020

@krizzu finally, checks are green now ✔

@krizzu
Copy link
Member

krizzu commented Apr 14, 2020

@kaiguo Great work 👏 Going to check it out later today

krizzu
krizzu approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left small question regarding bundling, but otherwise looks good 💪

@krizzu
Copy link
Member

krizzu commented Apr 17, 2020

Great! I'm go ahead and merge it. Thanks a lot for this! 🥇

@krizzu krizzu merged commit e7e3a4f into react-native-async-storage:master Apr 17, 2020
@kaiguo kaiguo deleted the upgrade-sample-app-to-61 branch April 17, 2020 17:32
@kaiguo
Copy link
Contributor Author

kaiguo commented Apr 17, 2020

Thanks @krizzu! I'm going to merge this into the windows PR and address some opening comments there, then I think we are ready to get that merged in too as long as it looks good to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krizzu krizzu krizzu approved these changes

@gre gre gre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade sample apps to use RN 61
3 participants
@kaiguo @krizzu @gre