-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sqlite-storage): scaffold workspace #1071
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
662456f
chore(deps): bump follow-redirects from 1.15.4 to 1.15.6 (#1074)
dependabot[bot] 864626d
feat(default-storage): Add Privacy Manifest for iOS (#1075)
krizzu 9fa27cc
chore(release): 1.23.0 [skip ci]
AsyncStorageBot c4ed1fa
fix(default-storage): Privacy manifest missing key (#1076)
krizzu 39adcfa
chore(release): 1.23.1 [skip ci]
AsyncStorageBot 17e0e33
chore(deps): bump webpack-dev-middleware from 5.3.3 to 5.3.4 (#1077)
dependabot[bot] d4a3eee
chore: GH workflows, turbo and other chores (#1073)
krizzu 740e424
init
krizzu 86eb94f
examples
krizzu 322c03a
comments
krizzu 7c7e5f3
fix glob
krizzu 5e39eb9
namespace
krizzu 87ee8a4
windows build
krizzu 7538c01
fixing windows action
krizzu d50f198
android example search for node_modules
krizzu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,6 +123,21 @@ jobs: | |
uses: actions/checkout@v4 | ||
- name: Setup project | ||
uses: ./.github/actions/setup-project | ||
with: | ||
windows-fix: true | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ inputs.node-version }} | ||
cache: "yarn" | ||
- name: Enable corepack | ||
shell: bash | ||
run: | | ||
corepack enable | ||
yarn --version | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ inputs.node-version }} | ||
cache: "yarn" | ||
- name: Set up MSBuild | ||
uses: microsoft/[email protected] | ||
- name: Setup VSTest.console.exe | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1 @@ | ||
it.todo("write a test"); | ||
|
||
function x(_: number) {} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If corepack randomly fails on Windows, maybe we shouldn't enable it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GH action failed because it was not enabled in first place - that issue came from setup-node itself. Running it first without the cache enables corepack properly (probably not doing checks for yarn versions behind the scene). So the fix here is simply setting node + corepack then enable cache