Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): add buildFeatures.buildConfig for android gradle plugin 8 #1026

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

mikehardy
Copy link
Contributor

Summary

Upcoming react-native 0.73+ includes android gradle plugin 8+ which needs namespace in build.gradle but also needs buildFeatures.buildConfig enabled as well

It is not sufficient to enable this at the top-level app build.gradle, specific modules that use it (such as those that implement new architecture, it seems) must also enable it at the module level

This change was necessary and is in-use in my work app via patch-package as I work through android-gradle-plugin 8+ issues in prep for react-native 0.73 launching for everyone

It is similar to changes I needed to do as react-native-firebase maintainer --> invertase/react-native-firebase@b52d0ce

Test Plan

With apologies, you have to alter an app that integrates this module to use android gradle plugin 8, it's difficult to do that in repos I'm proposing these changes in because bumping to android gradle plugin 8 requries a large amount of transitive dependency changes in CI

I have integrated this in an app and tested it, and done similar work as maintainer of react-native-firebase, react-native-netinfo and react-native-device-info, and I'm now pushing these out to the repos

Cheers

@krizzu
Copy link
Member

krizzu commented Nov 10, 2023

Thanks Mike, make total sense 👍

@krizzu krizzu merged commit f54a93b into react-native-async-storage:main Nov 10, 2023
9 checks passed
@AsyncStorageBot
Copy link
Collaborator

🎉 This PR is included in version 1.19.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mikehardy mikehardy deleted the patch-1 branch November 10, 2023 14:33
@mikehardy
Copy link
Contributor Author

Awesome, if this has problems for some reason (you never know?) you can @ me and I'll try to figure it out + clean up. Thanks for helping maintain a package I use! Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants