Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move files around, new lint rules #1007

Merged
merged 7 commits into from
Sep 1, 2023
Merged

chore: Move files around, new lint rules #1007

merged 7 commits into from
Sep 1, 2023

Conversation

krizzu
Copy link
Member

@krizzu krizzu commented Aug 31, 2023

Summary

  • Moved common config files to root .config directory
  • Bumped Prettier to latest supported (still v2) + allowed for default config
  • Ran eslint --fix against latest changes
  • Moved Contributions to .github directory
  • Actions now will run tests in both workspaces

@krizzu krizzu requested a review from tido64 as a code owner August 31, 2023 10:39
krizzu
krizzu commented Aug 31, 2023
View reviewed changes
.config/.eslintrc Outdated Show resolved Hide resolved
tido64
tido64 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 👍

.config/.eslintrc Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this file be in root? Would we still pass the checklist in https://github.com/react-native-async-storage/async-storage/community?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can live in .github
https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors#adding-a-contributing-file

.config/.clang-format Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this file in root for now since there are no nearest config file for IDEs to pick up. Either that, or we start adding .clang-format to individual packages that extend this one (I'm not sure this is supported).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So let's do this once there'll be more packages that uses clang format 👍

@krizzu krizzu enabled auto-merge (squash) August 31, 2023 12:06
@krizzu krizzu merged commit 69fc7d1 into main Sep 1, 2023
@krizzu krizzu deleted the chore/move-around branch September 1, 2023 15:43
@AsyncStorageBot
Copy link
Collaborator

🎉 This PR is included in version 1.19.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tido64 tido64 tido64 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krizzu @AsyncStorageBot @tido64