-
-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Resolve incorrect rendering of some colored icons #830
base: master
Are you sure you want to change the base?
Conversation
abb710c
to
1a16cb1
Compare
1a16cb1
to
6c801aa
Compare
@kamijin-fanta When is this going to be merged? I want to use GrChrome in Grommet Icons but now I can't use this |
@kimtaejin3 Thanks for your contribution. If multiColor is enabled, changing the color of icons with color props will not work. grommet-Icons include some colored icons, but most are single-color icons. Twotone in Ant Design Icons may be good with mutiColor enabled. |
@kamijin-fanta Thanks for replying! Then why don't you enable multicolor only for Twotone in Ant Design Icons? I think we need to think more about Grommet Icons |
I have looked into what happened with grommet-Icons. ✅OK / ⚠OK, but color is overrided / 🚫NG
The library adds Twotone in Ant Design Icons should be included in the library update. |
This change will be released as v4.12.0. |
039502a
to
399b45c
Compare
I solved the issue I mentioned in #827
@kamijin-fanta @gorangajic Could you please review this?