remove unnecessary global typescript namespace declaration #690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaring a global module with
declare module 'react-draggable'
is unnecessary, and can cause type pollution if multiple versions ofreact-draggable
end up in a package.This is exemplified in this repro: https://github.com/pgoldberg/react-draggable-typings-bug
The global module declaration is not necessary. Typescript will appropriately associate the typings with the
react-draggable
module, since the typings are declared in the package.json here:react-draggable/package.json
Line 24 in 44a8c6e