Fix git URL installation #546
Conversation
The intended behaviour is to run the build on any install, including from a git URL. See also: apiaryio/dredd#945 npm/npm#3055
Inline build instructions from Makefile to avoid dependency on make and yarn.
|
Thanks! |
|
Although, why avoid using make/yarn at prepare time? We want to ensure we're really using the correct build script, and this adds maintenance overhead if we change the build. |
|
The answer to your direct question is: to allow installation from Git URLs in environments where either yarn or make are not installed; likely that's not what you wanted to hear. I would ask the opposite question, i.e. 'why use make&yarn at all instead of having the command line mentioned in the commit go to the "build" script, and have "prepare" just run "build"?'. It's a matter of taste, and up to you really, I don't intend to force you in any way; you can always merge only the first patch, or ignore the issue entirely. |
|
Would agree with you that Make is a superfluous dependency here and isn't really used for anything that |
These commits make it possible to install this package from a git URL.