Attaches DayPicker caret to inputs instead of the picker component #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
so much cleaner, nice @majapw |
majapw
force-pushed
the
maja-attach-picker-caret-to-input
branch
from
1b2662d
to
7d6e129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I've been thinking about this problem specifically for #83, and after @travisbloom introduced
anchorDirectionin (#72, it became pretty clear that we were doing a lot of grossness to make carets consistently align. Combine this with the fact that we have to override caret styles at Airbnb for medium breakpoints, and the point is that I was getting annoying.While it makes some sense to attach the caret to the
DateRangePicker__picker, I think it actually makes more sense for placement to attach them to the inputs.to: @airbnb/webinfra