Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hasControlInside prop to enable/disable button like behavior - tabIndex and role on the wrapper #521

Conversation

vtx-anton-chashchin
Copy link
Contributor

Based on this discussion ant-design/ant-design#46215
added the property hasControlInside which manages tabIndex and role attributes on the wrapper of Upload component to prevent nesting of focusable elements and a11y issues in situation like this:

<Upload>
  <button>Upload</button>
</Upload>

To disable "button like" behavior and double focus when Upload contains controls inside now we can use it this way:

<Upload hasControlInside>
  <button>Upload</button>
</Upload>

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
upload ❌ Failed (Inspect) Dec 5, 2023 11:59am

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3dacfff) 87.10% compared to head (2d442be) 87.20%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
+ Coverage   87.10%   87.20%   +0.09%     
==========================================
  Files           6        6              
  Lines         256      258       +2     
  Branches       63       65       +2     
==========================================
+ Hits          223      225       +2     
  Misses         33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 4dcdebe into react-component:master Dec 5, 2023
8 of 9 checks passed
@mellis481
Copy link

@afc163 Thanks for merging this so quickly! Any idea when it will be released?

@vtx-anton-chashchin
Copy link
Contributor Author

@afc163 Hi, just a kindly reminder about release or any release plans/news for this PR

@afc163
Copy link
Member

afc163 commented Dec 13, 2023

https://github.com/react-component/upload/releases/tag/v4.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants