-
-
Notifications
You must be signed in to change notification settings - Fork 619
fix: duplicate unique identifiers in MeasureRow column headers #1378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cactuser-Lu
wants to merge
4
commits into
react-component:master
Choose a base branch
from
cactuser-Lu:fix-duplicate-id-for-measurerow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /** | ||
| * Attributes that should be removed from measure row DOM to avoid conflicts | ||
| */ | ||
| const FILTERED_ATTRIBUTES = [ | ||
| // Unique identifiers that shouldn't be duplicated in DOM | ||
| 'id', | ||
| 'data-testid', | ||
| 'data-test-id', | ||
| 'data-cy', // Cypress | ||
| 'data-qa', | ||
| 'data-automation-id', | ||
| 'data-id', | ||
| 'data-key', | ||
| ] as const; | ||
|
|
||
| /** | ||
| * Remove all ID and test attributes from DOM element and its descendants | ||
| * This ensures the measure row complies with HTML spec (no duplicate IDs) | ||
| * and works with custom components whose internal DOM we cannot control at React level | ||
| * @param element - The DOM element to clean | ||
| */ | ||
| export function cleanMeasureRowAttributes(element: HTMLElement): void { | ||
| if (!element) return; | ||
|
|
||
| const allElements = element.querySelectorAll('*'); | ||
| allElements.forEach(el => { | ||
| FILTERED_ATTRIBUTES.forEach(attr => { | ||
| el.removeAttribute(attr); | ||
| }); | ||
| }); | ||
| } | ||
|
Comment on lines
+22
to
+31
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 函数未清理根元素本身的属性。
应用此修复: export function cleanMeasureRowAttributes(element: HTMLElement): void {
if (!element) return;
+ // Remove attributes from the element itself
+ FILTERED_ATTRIBUTES.forEach(attr => {
+ element.removeAttribute(attr);
+ });
+
+ // Remove attributes from all descendants
const allElements = element.querySelectorAll('*');
allElements.forEach(el => {
FILTERED_ATTRIBUTES.forEach(attr => {
el.removeAttribute(attr);
});
});
}🤖 Prompt for AI Agents |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
当前使用
element.querySelectorAll('*')的实现只选择了后代元素,而没有包含element本身。如果传递给此函数的根元素自身也包含需要过滤的属性,这些属性将不会被移除。为了使此函数更加健壮,它也应该清理根元素上的属性。