Skip to content

fix(MeasureRow): clone the column without ref so that ref can point to the real columnHeader. #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2025
Merged

fix(MeasureRow): clone the column without ref so that ref can point to the real columnHeader. #1362

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11266dc
fix(MeasureRow): clone the column without ref so that ref can point t…
Linkodt Sep 18, 2025
7c534bc
fix(Body/MeasureRow): fix the type error when clone ReactElement
Linkodt Sep 19, 2025
e2ee887
Refactor titleForMeasure assignment logic
li-jia-nan Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Body/MeasureRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,16 @@ const MeasureRow: React.FC<MeasureRowProps> = ({
>
{columnsKey.map(columnKey => {
const column = columns.find(col => col.key === columnKey);
const rawTitle = column?.title;
const titleForMeasure = React.isValidElement(rawTitle)
? React.cloneElement(rawTitle, { ref: null })
: rawTitle;
return (
<MeasureCell
key={columnKey}
columnKey={columnKey}
onColumnResize={onColumnResize}
title={column?.title}
title={titleForMeasure}
/>
);
})}
Expand Down
Loading