feat: add dataIndex type check #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1091 +/- ##
=======================================
Coverage 97.96% 97.96%
=======================================
Files 51 51
Lines 4671 4671
Branches 592 592
=======================================
Hits 4576 4576
Misses 91 91
Partials 4 4 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Mar 22, 2024
|
就剩下2处了，为什么会报错？
|
第二处解决了，是因为有一处在 master 就漏掉了，没加 RecordType |
zombieJ
reviewed
Mar 25, 2024
|
还有的，之前本来就有错误
|
zombieJ
reviewed
Mar 25, 2024
zombieJ
reviewed
Mar 25, 2024
crazyair
commented
Mar 26, 2024
afc163
reviewed
Mar 27, 2024
| @@ -40,7 +40,7 @@ export default function useCellRender<RecordType>( | |||
| ? dataIndex | |||
| : [dataIndex]; | |||
|
|
|||
| const value: React.ReactNode = getValue(record, path); | |||
| const value: React.ReactNode = getValue(record, path as any); | |||
There was a problem hiding this comment.
之前的 path 是 any 类型，所以这里没报错，而现在类型是这样的
zombieJ
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: ant-design/ant-design#48023