onBeforeChange is fired multiple times

[ethansisson]

onBeforeChange fires between two and three times every time I click the handle or the track. I haven't noticed this happening when I click and drag the handle.

[brenoos]

I'm getting the same problem with onAfterChange, did you get the solution?

[LarsEllefsen]

Same issue here, but on "onAfterChange"

[anarchistgeek]

+1. Apparently, this is introduced in 8.6.3 and 8.6.4

[ciulic]

+1
On click I have these events being fired:
onSliderBeforeChange
onSliderBeforeChange
onSliderChange
onSliderAfterChange
onSliderBeforeChange

[meikidd]

Same here +1. And for those who looking for solution, it is mentioned in #495 that version 8.6.1 works well.
@brenoos

[xieqingtian]

Same issue here, when I click the sliderBar
https://codesandbox.io/s/843r09wk6l

[BrandonMathis]

For onAfterChange, perhaps it is related to this event being fired on ontouchend or onmouseup is triggered?

Seems that onAfterChange happens durring the onEnd event which is fired onBlur. I am starting to think that onBlur happens but then I am done dragging my slider (when I mouseup to let go) and when I loose focus of the slider (click on anything other than the slider).

[abhijit-padhy]

Hi Owner,
Can you add e.stopPropagation(); at the end of end() method inside slider.js and then try.

[LihayMorad]

Same here +1. And for those who looking for solution, it is mentioned in #495 that version 8.6.1 works well.
@brenoos

Thanks, I downgraded to v8.6.1 and it solved the problem for now (for onAfterChange).

[a-borodko]

Any change on this?
Downgrading is not an option for me, I need latest version features.

[dasl-]

I believe I have a fix.

Background: in version 8.6.1, clicking the rail (aka the "track") resulted in three events firing: onBeforeChange, onChange, and onAfterChange. This was the correct behavior.

In subsequent versions, the correct events were not always firing. Sometimes too few or sometimes too many would fire.

For instance, in version 9.7.5, we fired too many events: onBeforeChange, onChange, onBeforeChange, onAfterChange.

In version 10.0.0-alpha.5, we fire too few events: onChange, onAfterChange.

I have a patch that fixes the event firing in v10: #822 . I hope it gets merged soon. Until my patch gets merged, you can use my fork instead. Update your package.json like so: dasl-/piwall2@e7becfb#diff-012b982f97a0d326aeec58dd3b789484b05a944d609afe1b8ed5e299fc485f61

Then you will be using my fork of v10: https://github.com/dasl-/slider/tree/click-rail-publish

[dasl-]

my fix was merged:
#822