[added] Collapsible Panel transition hooks #1664
Merged
+51
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I just realized I forgot to push some changes to this branch. Will fix when I have access to that machine later today. |
martijnvermaat
force-pushed
the
panel-collapse
branch
from
376ad36 to
0c57c24
Compare
|
This is now working. The passed props are now just enumerated explicitely. Please let me know if you would like me to change anything. |
|
LGTM, need one more @react-bootstrap/collaborators to ok it |
|
I don't write my empty arrows without spacing ( |
taion
added a commit
that referenced
this pull request
Feb 24, 2016
[added] Collapsible Panel transition hooks
|
@mathieumg Me neither, I copied that code from another similar test and didn't notice. It occurs quite a lot in the tests. Thanks all for having a look and merging! |
4 tasks
martijnvermaat
added a commit
to lumc-nested/nested-editor
that referenced
this pull request
Apr 16, 2016
This fixes resizing of the editor on collapsing the examples panel. react-bootstrap/react-bootstrap#1664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1540
I found a number of different strategies for passing props to children in the codebase. Here I tried to minimize duplication of proptype definitions and their documentation.
For some reason the docs fail to build with a
TypeError: Converting circular structure to JSONand this seems to be due to how I extended the proptypes. I don't yet understand why, any hints are appreciated.