test_runner: check if timeout was cleared by own callback

PR-URL: nodejs#51673
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>

lib/internal/test_runner/mock/mock_timers.js

@@ -622,8 +622,12 @@ class MockTimers {
       if (timer.runAt > this.#now) break;
       FunctionPrototypeApply(timer.callback, undefined, timer.args);
 
-      this.#executionQueue.shift();
-      timer.priorityQueuePosition = undefined;
+      // Check if the timeout was cleared by calling clearTimeout inside its own callback
+      const afterCallback = this.#executionQueue.peek();
+      if (afterCallback.id === timer.id) {
+        this.#executionQueue.shift();
+        timer.priorityQueuePosition = undefined;
+      }
 
       if (timer.interval !== undefined) {
         timer.runAt += timer.interval;

test/parallel/test-runner-mock-timers.js

@@ -532,6 +532,22 @@ describe('Mock Timers Test Suite', () => {
           await nodeTimersPromises.setImmediate(); // let promises settle
           assert.strictEqual(f2.mock.callCount(), 1);
         });
+
+        it('should not affect other timers when clearing timeout inside own callback', (t) => {
+          t.mock.timers.enable({ apis: ['setTimeout'] });
+          const f = t.mock.fn();
+
+          const timer = nodeTimers.setTimeout(() => {
+            f();
+            // Clearing the already-expired timeout should do nothing
+            nodeTimers.clearTimeout(timer);
+          }, 50);
+          nodeTimers.setTimeout(f, 50);
+          nodeTimers.setTimeout(f, 50);
+
+          t.mock.timers.runAll();
+          assert.strictEqual(f.mock.callCount(), 3);
+        });
       });
 
       describe('setInterval Suite', () => {