Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1 #64

Merged
merged 3 commits into from
Mar 20, 2022
Merged

PHP 8.1 #64

merged 3 commits into from
Mar 20, 2022

Conversation

tobias-trozowski
Copy link
Contributor

  • added support for php 8.1
  • removed composer.lock
  • fixed unit tests

@tobias-trozowski
Copy link
Contributor Author

ping @rdohms
i'd really appreciate if you had some time and can have a look into this so this package is also usable for php 8.1.

@rdohms
Copy link
Owner

rdohms commented Mar 13, 2022

Sorry @tobias-trozowski will try to get to it this week.

@rdohms
Copy link
Owner

rdohms commented Mar 15, 2022

@tobias-trozowski can you double check the Code style issues?
Did you find removing the lock had any effect? I like to keep lock files as a tool for contributors to know what they are coding against and reducing friction. Since we run a composer update in the tests the lock file should not interfere there only in devs running an install locally.

@tobias-trozowski
Copy link
Contributor Author

IMO there's no use for the lock file here as we are testing against latest and lowest. it's just one more thing which can cause friction (e.g. merge conflicts).

@rdohms
Copy link
Owner

rdohms commented Mar 16, 2022

@tobias-trozowski its mostly for local testing and contributor experience.

@tobias-trozowski
Copy link
Contributor Author

@rdohms so shall i revert the removal? IMO it's not needed but i'm happy to add it again if you want it back

@rdohms
Copy link
Owner

rdohms commented Mar 16, 2022

If you could drop that commit it would be great. the rest looks good to merge.

@tobias-trozowski
Copy link
Contributor Author

@rdohms commit removed

@rdohms rdohms merged commit 9fe26b5 into rdohms:master Mar 20, 2022
@rdohms rdohms added this to the v4.0.2 milestone Mar 20, 2022
@rdohms rdohms added Dependencies Automatic/Manual updates to project dependencies and changes related to these updates only CI This issue or pull request is related to the build process labels Mar 20, 2022
@rdohms
Copy link
Owner

rdohms commented Mar 20, 2022

Released as 4.0.2, thanks!

@tobias-trozowski
Copy link
Contributor Author

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdohms rdohms rdohms approved these changes

Assignees
No one assigned
Labels
CI This issue or pull request is related to the build process Dependencies Automatic/Manual updates to project dependencies and changes related to these updates only
Projects
None yet
Milestone
v4.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@tobias-trozowski @rdohms