Wip separate injector contexts rebase #196
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the current use of the extra args in Injector::execute() and Injector::make() are powerful, they are also dangerous.
They can lead to 'surprising' behaviour where data is shared inappropriately:
by allowing a separate context/injector to be created, the correct behaviour can be done by defining things that should't be shared, on the separated context.
Note, this doesn't prevent users from accidentally sharing data inappropriately.
The
$separate_injector
would still be able to access that message. It only makes it possible to not do it.API and names are not super great currently. Open to improvement on them.
Also, if someone is separating a context, they are probably going to do something with it very soon, so we could make it possible to pass in shares, defines etc.