Compatibility updates for GeometryBasics #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I should mention that watching this package's unit tests running was the most entertaining unit testing I have ever experienced.
|
Collaborator
Author
|
Hmm, do you know why the GitHub checks are failing, @rdeits? I'm guessing it's something with the GitHub actions since all tests passed on my local machine. |
Collaborator
Author
|
Never mind what I said in the comment above. This is now ready to be merged. |
Collaborator
Author
|
When this is merged, we can also just close #201. |
Owner
|
Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
Point3f0toPoint3f, following JuliaGeometry/GeometryBasics.jl#97.I did run the script provided in the PR link above to rename other types, but these were the only occurrences that needed renaming.