-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.1.0 Search API: Retain nesting of queries, Data API: add querying for all structures #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/first being accessed
Co-authored-by: Dennis Piehl <[email protected]>
Search API: Retain nesting of queries, Data API: add querying for all structures
piehld
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again @ivana-truong! This all looks excellent!
Linking to the original PR to staging
here for reference: #50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search API
__and__
/__or__
method ofSearchQuery
and addedgroup
method in response to Issue in grouped attribute search #49. Now building queries withgroup
function will cause the group to be preserved while constructing the rest of the queryData API
const.py
/data.__init__.py
. This can be passed into theinput_ids
parameter to make a query for all structures. Currently supportsentries
andchem_comps
input_type
sprogress_bar
parameter to.exec
. If set toTrue
, there will be a progress bar for the executing query.batch_size
parameter to.exec
. Defaults to 5,000.Misc