Add new influxdb metrics reporter #273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihasya
requested changes
Mar 13, 2020
| @@ -160,7 +160,7 @@ Clients are available for the following destinations: | |||
| * AppOptics - https://github.com/ysamlan/go-metrics-appoptics | |||
| * Librato - https://github.com/mihasya/go-metrics-librato | |||
| * Graphite - https://github.com/cyberdelia/go-metrics-graphite | |||
| * InfluxDB - https://github.com/vrischmann/go-metrics-influxdb | |||
| * InfluxDB - https://github.com/vrischmann/go-metrics-influxdb / https://github.com/tehsphinx/metrics | |||
There was a problem hiding this comment.
Can I suggest naming your repo something more descriptive? go-metrics-influxdb-alt or something along those lines? I know, I know, naming is hard, but I feel like just calling it "metrics" is asking for trouble down the lines
There was a problem hiding this comment.
sounds reasonable. I will try to think of something. Problem ist that the name should also be the package name.
There was a problem hiding this comment.
@mihasya: What do you think of fluxmetrics?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rcrowley: I have written a new metrics reporter for influxDB. It uses the same data-layout as the one from @vrischmann but solves a problem I had with vrischmann's data reporter: It needs a new reporter per influxDB measurement. That also means with each new measurement another goroutine and another call to influxDB every x seconds.
With this metrics reporter, one is enough for all metrics and measurements in the entire application.
Unfortunately that meant breaking API changes, so I decided to write my own.