Partial workaround for timer during a clock jump #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentbernat
force-pushed
the
fix/negative-time
branch
from
735b61b
to
e813551
Compare
`time.Now()` uses the wall-clock and therefore calling it twice, one second apart, can produce quite different results (negative results but also a difference greater than one second). Go doesn't expose a monotonic clock, therefore, it's difficult to properly fix (but there is https://github.com/gavv/monotime if we want a proper fix for `timer.Time()`). This workaround just discard any negative duration.
vincentbernat
force-pushed
the
fix/negative-time
branch
from
e813551
to
bd98a3a
Compare
vincentbernat
force-pushed
the
fix/negative-time
branch
from
bd98a3a
to
0d432c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time.Now()uses the wall-clock and therefore calling it twice, onesecond apart, can produce quite different results (negative results but
also a difference greater than one second). Go doesn't expose a
monotonic clock, therefore, it's difficult to properly fix (but there is
https://github.com/gavv/monotime if we want a proper fix for
timer.Time()).This workaround just discard any negative duration.
There are other places that incorrectly uses
time.Now(). I can add a similar check or I can importmonotimeto properly fixes them.