Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests about comparing Arc<dyn KernelObject> #173

Merged
merged 1 commit into from
Sep 6, 2020
Merged

fix tests about comparing Arc<dyn KernelObject> #173

merged 1 commit into from
Sep 6, 2020

Conversation

xxchan
Copy link
Contributor

@xxchan xxchan commented Sep 5, 2020

These sometimes fail on my computer.
Comparing fat pointers to trait objects seems to be unstable.
ref: rust-lang/rust#46139 rust-lang/rust#69757

@coveralls
Copy link

coveralls commented Sep 5, 2020

Pull Request Test Coverage Report for Build 240640358

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 49.012%

Files with Coverage Reduction New Missed Lines %
linux-object/src/fs/pipe.rs 1 89.74%
linux-object/src/fs/file.rs 2 62.77%
Totals Coverage Status
Change from base Build 239040782: -0.01%
Covered Lines: 7418
Relevant Lines: 15135

💛 - Coveralls

@wangrunji0408
Copy link
Member

Oh. These tests also failed on my macOS.

@wangrunji0408 wangrunji0408 merged commit dd3ecab into rcore-os:master Sep 6, 2020
@wangrunji0408 wangrunji0408 added the bug Something isn't working label Sep 6, 2020
zhangsn-19 pushed a commit to zhangsn-19/zCore that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants