forked from tc39/ecma262
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more suggested changes #11
Open
jmdyck
wants to merge
10
commits into
rbuckton:explicit-resource-management
Choose a base branch
from
jmdyck:3000_ed3
base: explicit-resource-management
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on May 27, 2024
-
After a colon, we don't use "one of" or "either"
(except to disambiguate) See tc39#2972 (comment)
Configuration menu - View commit details
-
Copy full SHA for 5ada0af - Browse repository at this point
Copy the full SHA 5ada0afView commit details -
Simplify IsUsingDeclaration & IsAwaitUsingDeclaration
As far as I can tell, the existing definitions have a lot of prodictions that the SDO can't reach.
Configuration menu - View commit details
-
Copy full SHA for 875245e - Browse repository at this point
Copy the full SHA 875245eView commit details -
Drop AwaitExpression from IsFunctionDefinition, AssignmentTargetType,…
… HasCallInTailPosition I don't think it can be reached by these SDOs any more.
Configuration menu - View commit details
-
Copy full SHA for dfb1127 - Browse repository at this point
Copy the full SHA dfb1127View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d98ab2 - Browse repository at this point
Copy the full SHA 9d98ab2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 398f7ab - Browse repository at this point
Copy the full SHA 398f7abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00ba082 - Browse repository at this point
Copy the full SHA 00ba082View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3af31ae - Browse repository at this point
Copy the full SHA 3af31aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3875d86 - Browse repository at this point
Copy the full SHA 3875d86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 845f465 - Browse repository at this point
Copy the full SHA 845f465View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7caee60 - Browse repository at this point
Copy the full SHA 7caee60View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.