Minor tweaks to make the code play nice on other platforms - #1
Merged
rbomze merged 2 commits intoNov 26, 2025
Conversation
Columbo818
commented
Nov 26, 2025
Columbo818
commented
Collaborator
- Moved the import of sleep.h inside of a conditional check to ensure platform compatability.
- Removed the explicit priority settings for nodes not in the SENSOR role - we dont want to affect other roles.
Relocates the conditional setting of nRFSenseSleep for NRF52 architecture from runOnce() to the header section, ensuring it is set earlier in the module lifecycle. This change means that the sleep lib is only imported on supported platforms, reducing binary size on other platforms
Eliminated the explicit setting of BACKGROUND priority for non-sensor devices in sendCurrentStateMessage. This would otherwise affect all nodes using the DetectionSensor module in roles other than Sensor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.