Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria2c doesn't support writing remote content to stdout #965

Merged
merged 5 commits into from
Aug 12, 2016

Conversation

yyuu
Copy link
Contributor

@yyuu yyuu commented Jun 2, 2016

I've implemented aria2c support in #904. However, I finally realized that aria2c doesn't support writing remote content to stdout (aria2/aria2#190).

I confirmed that basically this must be not a problem for ruby-build since it doesn't rely on http get without filename (the only usage of http get is specifying its destination filename). It'd be better to be fixed though.

@mislav
Copy link
Member

mislav commented Jun 2, 2016

Thanks for catching this. Like my comment in #904 (comment), I don't like that every tweak to aria2c support needs to touch all tests. Is there a way we can circumvent this? Maybe go back to stubbing curl instead, and aria2c as uninstalled on the system, and then have just one test that stubs aria2c as supported and tests its invocation?

@yyuu
Copy link
Contributor Author

yyuu commented Jun 3, 2016

It sounds nicer than current test impl..... I'll try to do it later.

@yyuu yyuu force-pushed the workaround-aria2c-stdout branch from 9feae21 to 63e76cc Compare June 10, 2016 06:05
@yyuu
Copy link
Contributor Author

yyuu commented Jun 10, 2016

I've prepared test helper to remove aria2c from $PATH. Now we can use curl stub during test as same as before. I've prepared dedicated test case for aria2c and it'd be sufficient to check if aria2c is working.

@mislav could you review the changes again?

yyuu added a commit to pyenv/pyenv that referenced this pull request Jun 21, 2016
@mislav
Copy link
Member

mislav commented Aug 12, 2016

Thanks for doing all the work and being patient!

@yyuu yyuu deleted the workaround-aria2c-stdout branch August 15, 2016 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants