Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pad preview document body instead of iframe element #2

Merged
merged 25 commits into from
Mar 1, 2020
Merged

Pad preview document body instead of iframe element #2

merged 25 commits into from
Mar 1, 2020

Conversation

rbardini
Copy link
Owner

@rbardini rbardini commented Feb 29, 2020 •
edited
Loading

What this PR does

Add paddings to the preview document body instead of the iframe element, to better support Storybook's new layout parameter and prevent hiding overflown content (e.g. cut-off shadows).

Demo

Changelog

  • Add withPaddings decorator
  • Update README with decorator usage
  • Migrate example to storybook/react with elevated card example
  • Remove default margins from example preview
  • Refactor PaddingSelector component
  • Update linting rules and dependencies

Closes #1

@rbardini
remove global styles from padding selector
e074508
@rbardini
migrate example from HTML to React
d2b6e05
@rbardini
add withPaddings decorator
e528abd
@rbardini
update linting rules
e9813c6
@rbardini
wrap decorated story with fragment
0db7784
@rbardini
use Global component to add styles
07560fc
@rbardini
update README
d7e722f
@rbardini
type onUpdate listener
b863faa
@rbardini
use global state to keep paddings between stories
149b189
@rbardini
only set paddings if addon is not disabled
6612036
@rbardini
don't run decorator if no options or params set
1f2b44a
@rbardini
convert padding selector to functional compoenent
2404957
@rbardini
normalize default selected
93a5dc7
@rbardini
use useParameter hook
214c3fc
@rbardini
enforce Rules of Hooks
cb24c9c
@rbardini
only emit selected padding value
abec15f
@rbardini
move all types to the top of the file
a2e331a
@rbardini
set initial padding from decorator wrapper
8248363
@rbardini
pass story as children to decorator wrapper
84de6b4
@rbardini
use empty string as default padding
c41a291
@rbardini
add Card story example
d05ae7e
@rbardini
remove preview body margin
60014ec
@rbardini
update dependencies
4076f69
@rbardini
update demo recording
6b60f5e
@rbardini
install example before linting
0309a6c
@rbardini rbardini added the enhancement New feature or request label Feb 29, 2020
@rbardini rbardini self-assigned this Feb 29, 2020
@rbardini rbardini merged commit 428c70a into master Mar 1, 2020
@rbardini rbardini deleted the pad-document branch March 1, 2020 15:36
@github-actions
Copy link

github-actions bot commented Mar 1, 2020

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rbardini rbardini

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pad preview document body instead of iframe element
1 participant
@rbardini