Type header components (hashicorp-forge#209)

razorpay · Jun 9, 2023 · bf6d127 · bf6d127
1 parent 64d6d65
commit bf6d127
Show file tree

Hide file tree

Showing 13 changed files with 79 additions and 12 deletions.
diff --git a/web/app/components/header/active-filter-list-item.hbs b/web/app/components/header/active-filter-list-item.hbs
@@ -1,4 +1,3 @@
-{{! @glint-nocheck: not typesafe yet }}
 <LinkTo @query={{this.query}} class="active-filter-list-item">
   <FlightIcon @name="x" />
   {{@filter}}

diff --git a/web/app/components/header/active-filter-list-item.ts b/web/app/components/header/active-filter-list-item.ts
@@ -29,3 +29,9 @@ export default class HeaderActiveFilterListItemComponent extends Component<Heade
     };
   }
 }
+
+declare module "@glint/environment-ember-loose/registry" {
+  export default interface Registry {
+    "Header::ActiveFilterListItem": typeof HeaderActiveFilterListItemComponent;
+  }
+}
diff --git a/web/app/components/header/active-filter-list.hbs b/web/app/components/header/active-filter-list.hbs
@@ -1,4 +1,3 @@
-{{! @glint-nocheck: not typesafe yet }}
 {{#if this.shownFilters.length}}
   <div class="active-filter-list">
     <h3>Showing</h3>

diff --git a/web/app/components/header/active-filter-list.ts b/web/app/components/header/active-filter-list.ts
@@ -29,3 +29,9 @@ export default class HeaderActiveFilterListComponent extends Component<HeaderAct
     page: 1,
   };
 }
+
+declare module "@glint/environment-ember-loose/registry" {
+  export default interface Registry {
+    "Header::ActiveFilterList": typeof HeaderActiveFilterListComponent;
+  }
+}
diff --git a/web/app/components/header/facet-dropdown.ts b/web/app/components/header/facet-dropdown.ts
@@ -3,18 +3,25 @@ import { FacetDropdownObjects } from "hermes/types/facets";
 import { inject as service } from "@ember/service";
 import RouterService from "@ember/routing/router-service";
 
-interface FacetDropdownComponentSignature {
+interface HeaderFacetDropdownComponentSignature {
+  Element: HTMLDivElement;
   Args: {
     label: string;
-    facets: FacetDropdownObjects;
+    facets: FacetDropdownObjects | null;
     disabled?: boolean;
   };
 }
 
-export default class FacetDropdownComponent extends Component<FacetDropdownComponentSignature> {
+export default class HeaderFacetDropdownComponent extends Component<HeaderFacetDropdownComponentSignature> {
   @service declare router: RouterService;
 
   protected get currentRouteName() {
     return this.router.currentRouteName;
   }
 }
+
+declare module "@glint/environment-ember-loose/registry" {
+  export default interface Registry {
+    "Header::FacetDropdown": typeof HeaderFacetDropdownComponent;
+  }
+}
diff --git a/web/app/components/header.hbs → web/app/components/header/index.hbs b/web/app/components/header.hbs → web/app/components/header/index.hbs
@@ -1,4 +1,3 @@
-{{! @glint-nocheck: not typesafe yet }}
 <header class="bg-color-page-faint border-b border-b-color-border-faint mb-7">
   <Header::Nav />
 </header>

diff --git a/web/app/components/header/index.ts b/web/app/components/header/index.ts
@@ -0,0 +1,14 @@
+import Component from "@glimmer/component";
+import { FacetDropdownGroups } from "hermes/types/facets";
+
+interface HeaderComponentSignature {
+  Args: {
+    facets: FacetDropdownGroups;
+    sortControlIsHidden?: boolean;
+  };
+}
+
+export default class extends Component<HeaderComponentSignature> {}
+declare module "@glint/environment-ember-loose/registry" {
+  export default interface Registry {}
+}
diff --git a/web/app/components/header/nav.ts b/web/app/components/header/nav.ts
@@ -10,11 +10,11 @@ import AuthenticatedUserService, {
 import window from "ember-window-mock";
 import { tracked } from "@glimmer/tracking";
 
-interface NavComponentSignature {
+interface HeaderNavComponentSignature {
   Args: {};
 }
 
-export default class NavComponent extends Component<NavComponentSignature> {
+export default class HeaderNavComponent extends Component<HeaderNavComponentSignature> {
   @service("config") declare configSvc: ConfigService;
   @service declare session: SessionService;
   @service declare router: RouterService;
@@ -84,3 +84,10 @@ export default class NavComponent extends Component<NavComponentSignature> {
     this.session.invalidate();
   }
 }
+
+declare module "@glint/environment-ember-loose/registry" {
+  export default interface Registry {
+    'Header::Nav': typeof HeaderNavComponent;
+  }
+}
+
diff --git a/web/app/components/header/search.ts b/web/app/components/header/search.ts
@@ -20,7 +20,12 @@ interface BasicDropdownAPI {
   };
 }
 
-export default class Search extends Component {
+interface HeaderSearchComponentSignature {
+  Element: HTMLDivElement;
+  Args: {};
+}
+
+export default class HeaderSearchComponent extends Component<HeaderSearchComponentSignature> {
   @service declare algolia: AlgoliaService;
   @service declare router: RouterService;
 
@@ -87,3 +92,9 @@ export default class Search extends Component {
     }
   );
 }
+
+declare module "@glint/environment-ember-loose/registry" {
+  export default interface Registry {
+    "Header::Search": typeof HeaderSearchComponent;
+  }
+}
diff --git a/web/app/components/header/sort-dropdown.ts b/web/app/components/header/sort-dropdown.ts
@@ -2,13 +2,15 @@ import Component from "@glimmer/component";
 import { SortByFacets, SortByValue } from "./toolbar";
 import { inject as service } from "@ember/service";
 import RouterService from "@ember/routing/router-service";
+import { Placement } from "@floating-ui/dom";
 
 interface HeaderSortDropdownComponentSignature {
   Args: {
     label: string;
     facets: SortByFacets;
     disabled: boolean;
     currentSortByValue: SortByValue;
+    dropdownPlacement: Placement;
   };
 }
 
@@ -27,3 +29,9 @@ export default class HeaderSortDropdownComponent extends Component<HeaderSortDro
     return SortByValue.DateAsc;
   }
 }
+
+declare module "@glint/environment-ember-loose/registry" {
+  export default interface Registry {
+    "Header::SortDropdown": typeof HeaderSortDropdownComponent;
+  }
+}
diff --git a/web/app/components/header/toolbar.hbs b/web/app/components/header/toolbar.hbs
@@ -1,4 +1,3 @@
-{{! @glint-nocheck: not typesafe yet }}
 {{#if @facets}}
   <div class="toolbar mb-7">
     <div class="x-container">

diff --git a/web/app/components/header/toolbar.ts b/web/app/components/header/toolbar.ts
@@ -147,3 +147,9 @@ export default class ToolbarComponent extends Component<ToolbarComponentSignatur
     });
   }
 }
+
+declare module "@glint/environment-ember-loose/registry" {
+  export default interface Registry {
+    "Header::Toolbar": typeof ToolbarComponent;
+  }
+}
diff --git a/web/app/components/header/user-menu-highlight.ts b/web/app/components/header/user-menu-highlight.ts
@@ -1,7 +1,13 @@
 import Component from "@glimmer/component";
 
-interface HeaderUserMenuHighlightsSignature {
+interface HeaderUserMenuHighlightSignature {
   Args: {};
 }
 
-export default class HeaderUserMenuHighlights extends Component<HeaderUserMenuHighlightsSignature> {}
+export default class HeaderUserMenuHighlight extends Component<HeaderUserMenuHighlightSignature> {}
+
+declare module "@glint/environment-ember-loose/registry" {
+  export default interface Registry {
+    "Header::UserMenuHighlight": typeof HeaderUserMenuHighlight;
+  }
+}