Add securityContext to deployment #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2019 14:14
Make sure we can run Razee Dashboard on a Kubernetes system where we don't allow containers to execute as root user.
Override the default workingDir for the container (/root) to enable running this deployment in a Kubernetes environment where this is not allowed via the Pod Security policy 'MustRunAsNonRoot'.
mckaymic
reviewed
Sep 20, 2019
| @@ -30,6 +30,9 @@ items: | |||
| app: razeedash | |||
| name: razeedash | |||
| spec: | |||
| securityContext: | |||
| fsGroup: 999 | |||
There was a problem hiding this comment.
Just curious. We've been using 1000 for the GIDs and UIDs. Any reason you use 999 or is it just habit?
There was a problem hiding this comment.
Just a habit, maybe a bad one. Sorry did not see this message until now
mckaymic
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we can run Razee Dashboard on a Kubernetes system
where we don't allow containers to execute as root user.