Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert duration to days and appeal rejection notification #377

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

Chief-Rishab
Copy link
Member

@Chief-Rishab Chief-Rishab commented Mar 31, 2023

  • convert duration to days if possible for slack approval notification
  • send appeal rejection notification for auto rejected steps, which got auto-rejected at appeal creation time
  • include labels from dataset & table when fetching resources (prevent Resource.Details["_metadata"] update from users in UpdateResource) (Fetch labels for bigquery dataset/table #372 )

@coveralls
Copy link

coveralls commented Mar 31, 2023

Pull Request Test Coverage Report for Build 4580552373

  • 84 of 128 (65.63%) changed or added relevant lines in 9 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 75.279%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/provider/service.go 2 3 66.67%
utils/time.go 12 13 92.31%
plugins/providers/bigquery/provider.go 23 26 88.46%
plugins/providers/bigquery/client.go 27 31 87.1%
plugins/providers/bigquery/model.go 8 20 40.0%
core/appeal/service.go 6 29 20.69%
Files with Coverage Reduction New Missed Lines %
plugins/providers/bigquery/provider.go 1 80.31%
plugins/providers/bigquery/client.go 2 20.74%
Totals Coverage Status
Change from base Build 4405106078: 0.2%
Covered Lines: 7951
Relevant Lines: 10562

💛 - Coveralls

@Chief-Rishab Chief-Rishab changed the title feat: convert duration to days for slack approval notification feat: convert duration to days and appeal rejection notification Mar 31, 2023
@ravisuhag ravisuhag merged commit 9dc15cb into main Apr 3, 2023
@ravisuhag ravisuhag deleted the feat/resource-metadata branch April 3, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants