Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grant): introduce update grant API #374

Merged
merged 2 commits into from
Mar 10, 2023
Merged

feat(grant): introduce update grant API #374

merged 2 commits into from
Mar 10, 2023

Conversation

rahmatrhd
Copy link
Member

closes #362

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4352280604

  • 63 of 74 (85.14%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 75.033%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/handler/v1beta1/grant.go 18 20 90.0%
core/grant/service.go 44 53 83.02%
Totals Coverage Status
Change from base Build 4340532339: 0.07%
Covered Lines: 7862
Relevant Lines: 10478
💛 - Coveralls

@mabdh mabdh self-requested a review March 10, 2023 02:23
@ravisuhag ravisuhag merged commit 975f5cb into main Mar 10, 2023
@ravisuhag ravisuhag deleted the update-grant branch March 10, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabdh mabdh mabdh approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@bsushmith bsushmith Awaiting requested review from bsushmith bsushmith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add API to assign/update owner of a grant
4 participants
@rahmatrhd @coveralls @mabdh @ravisuhag