-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gamepad Rework #821
Gamepad Rework #821
Conversation
Just noticed all the examples need updating... I shall get on that. |
Ok, just answered two of my three questions (TABS, gamepad examples). Third question: What about Android gamepad? I just been investigating it right now and it seems gamepad inputs on Android come in the form of key inputs... not sure how to deal with that properly... neither have an Android gamepad for testing... probably we can skip that part for now. |
I have ignored Android gamepads for now as I did not find them implemented and I am unsure as to how to add Android support to it. |
ok, do you want me to wait for the examples review before merging? |
Yeah please, I am just in the middle of updating the gamepad example to the correct enums, but nothing more. My aim is for it to build and the example to work, not worrying about controller identification for the moment. |
That should be it sorted, I'm going to wait for the build to complete before giving the go-ahead. |
take it easy, no hurries... :) |
It seems there is some issue on
|
Oh, I see, 2 seconds |
That should fix it |
@Rover656 Thnak you very much for another great contribution! :) |
This reworks gamepads so that all button and axis mappings go through the same enum, instead of controller specific controls.
Desktop and UWP Gamepads have been tested and work correctly. Desktop (on windows, if GLFW mapping works here, it should work everywhere else) has been tested with an XB1 and PS4 controller, and UWP just with the XB1.
Web has not been tested as I am unable to test, but what I have written comes straight from the w3 docs and so should be correctly mapping buttons and axis to the new enum's aswell.